Create mushy macroscale drainage timescale parameter #462
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…scale documentation
|
Do we need to test and merge quickly and get this onto the E3SM Icepack branch? Do you want me to do any testing on cheyenne or are you comfortable from your testing everything is bit-for-bit and working? That looks OK to me, but happy to do more. |
|
Yes, quickly please. It would be great if you can launch a quick test on cheyenne, but I don't expect any issues with these changes. |
|
I just fired up a test suite on cheyenne. Will approve and merge the PR after that, then create a PR back to E3SM Icepack cice-consortium/E3SM-icepack-initial-integration that @eclare108213 can merge there. |
apcraig
approved these changes
Sep 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Define a new parameter that sets the timescale (in days) for macroscopic drainage when using mushy thermodynamics. Fix some other documentation issues.
@eclare108213
178 measured results of 178 total results
178 of 178 tests PASSED
0 of 178 tests PENDING
0 of 178 tests MISSING data
0 of 178 tests FAILED
How much do the PR code changes differ from the unmodified code?
Does this PR create or have dependencies on CICE or any other models?
Does this PR add any new test cases?
Is the documentation being updated? ("Documentation" includes information on the wiki or in the .rst files from doc/source/, which are used to create the online technical docs at https://readthedocs.org/projects/cice-consortium-cice/.)
Please provide any additional information or relevant details below:
Define new parameter,
tscale_pnd_drain, that sets the timescale (in days) for macroscopic drainage when using mushy thermodynamics. This parameterization is described in Turner and Hunke 2015 (eqn 47). It contributes to flushing along with gravity drainage, and therefore is not the timescale for flushing overall.tscale_pnd_drain= 1 /lambda_pondin icepack_therm_mushy.F90.Note:
tscale_pnd_drainis not (yet) a namelist parameter, but it is now available in parameters for drivers to set their own values. This is needed for E3SM.Change the default value of
dpscale(scaling factor for meltpond flushing with BL99 thermo) to 1.e-3 in the code. This is the value used in icepack_in and all of our tests.Clarify definition of
dpscalein the code and documentation -dpscalealters the timescale for drainage but is only a unitless scaling factor.Fix enthalpy units in code comments. Closes #455 (CICE does not suffer from this issue).